christoph/reprored
1
0
Fork 0
Code Issues 1 Pull requests 1 Projects 1 Releases Packages Wiki Activity Actions

feature/dualtree #2

Open
christoph wants to merge 0 commits from feature/dualtree into main
pull from: feature/dualtree
merge into: christoph:main
Conversation 0 Commits - Files changed -
christoph commented 2025-01-15 10:19:21 +01:00
Owner
Copy link
No description provided. 
This new algorithm will use two binary trees, one  that defines the communication order, while the other defines the reduction order.
This excludes values that are just passed along the communication tree.
Support distributions with 0-length regions & arbitrary rank ordering
Fix various bugs related to 0-length regions
Clarify differences between rank & array order
Remove ubsan library flag
We can not fullfil the alignment criteria.
Previously, the algorithm would not recognize an element as passthrough if its subtree was not comm-local.
Move ScoreP compiler declaration to top of CMake file to avoid issues with build cache invalidation
This tidies up the profiling output
Previously, we stored incoming values in a map with the tree coordinate as key.
We now rely on the fact that the algorithm receives and accesses these values in-order.
While the reduce operation takes two operands from the stack, it also pushes it result resulting in a net stack size change of -1.
Reduce + Bcast
Allreduce
Allreduce with `par_unseq`
Required because of `std::execution::par_unseq` if TBB is installed.
This pull request has changes conflicting with the target branch.
  • src/allreduce_summation.cpp
  • src/c_wrapper.cpp
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/dualtree:feature/dualtree
git switch feature/dualtree

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff feature/dualtree
git switch feature/dualtree
git rebase main
git switch main
git merge --ff-only feature/dualtree
git switch feature/dualtree
git rebase main
git switch main
git merge --no-ff feature/dualtree
git switch main
git merge --squash feature/dualtree
git switch main
git merge --ff-only feature/dualtree
git switch main
git merge feature/dualtree
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: christoph/reprored#2
No description provided.
Delete branch "feature/dualtree"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?